Skip to content

fix(adkrest): accept functionCallEventId in run requests#977

Open
Zhang-986 wants to merge 1 commit into
google:mainfrom
Zhang-986:codex/accept-function-call-event-id
Open

fix(adkrest): accept functionCallEventId in run requests#977
Zhang-986 wants to merge 1 commit into
google:mainfrom
Zhang-986:codex/accept-function-call-event-id

Conversation

@Zhang-986

@Zhang-986 Zhang-986 commented Jun 7, 2026

Copy link
Copy Markdown

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

Problem:
The bundled ADK web UI sends functionCallEventId when resuming a long-running function call, but RunAgentRequest did not include that field. Because the REST decoder uses DisallowUnknownFields(), /api/run_sse rejected the request before the confirmation response could be processed.

Solution:
Add FunctionCallEventId to RunAgentRequest so the backend accepts the field while preserving strict unknown-field validation for other request keys. A regression test covers the decoder path used by /run_sse.

Testing Plan

Unit Tests:

  • I have added or updated unit tests for my change.
  • go test ./server/adkrest/controllers
  • git diff --check

Manual End-to-End (E2E) Tests:

Not run locally. The change is covered at the request decoder boundary that previously rejected the dev-ui payload.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • Relevant unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

This keeps strict JSON decoding enabled and only adds the field already sent by the bundled web UI for long-running function responses.

@google-cla

google-cla Bot commented Jun 7, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Zhang-986 Zhang-986 force-pushed the codex/accept-function-call-event-id branch from bdd746d to 984450d Compare June 7, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

POST /api/run_sse rejects functionCallEventId field sent by adk-web dev-ui

1 participant