fix(adkrest): accept functionCallEventId in run requests#977
Open
Zhang-986 wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
bdd746d to
984450d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Problem:
The bundled ADK web UI sends
functionCallEventIdwhen resuming a long-running function call, butRunAgentRequestdid not include that field. Because the REST decoder usesDisallowUnknownFields(),/api/run_sserejected the request before the confirmation response could be processed.Solution:
Add
FunctionCallEventIdtoRunAgentRequestso the backend accepts the field while preserving strict unknown-field validation for other request keys. A regression test covers the decoder path used by/run_sse.Testing Plan
Unit Tests:
go test ./server/adkrest/controllersgit diff --checkManual End-to-End (E2E) Tests:
Not run locally. The change is covered at the request decoder boundary that previously rejected the dev-ui payload.
Checklist
Additional context
This keeps strict JSON decoding enabled and only adds the field already sent by the bundled web UI for long-running function responses.