Skip to content

chore: Update tests for ToolRequestConfirmationAction #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+68 −2
Open

chore: Update tests for ToolRequestConfirmationAction #1109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 68 additions & 2 deletions core/src/test/java/com/google/adk/flows/llmflows/ToolRequestConfirmationActionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import com.google.genai.types.Content;
import com.google.genai.types.FunctionCall;
import com.google.genai.types.FunctionDeclaration;
import com.google.genai.types.Part;
import com.google.genai.types.Schema;
Expand Down Expand Up @@ -72,8 +73,29 @@ public Single<Map<String, Object>> runAsync(Map<String, Object> args, ToolContex
}
}

private static class NormalTool extends BaseTool {
NormalTool() {
super("normal_tool", "Normal tool.");
}

@Override
public Optional<FunctionDeclaration> declaration() {
return Optional.of(
FunctionDeclaration.builder()
.name(name())
.description(description())
.parameters(Schema.builder().type("OBJECT").build())
.build());
}

@Override
public Single<Map<String, Object>> runAsync(Map<String, Object> args, ToolContext toolContext) {
return Single.just(ImmutableMap.of("result", "success"));
}
}

@Test
public void toolRequestConfirmation_eventHasNonNullId() {
public void toolRequestConfirmation_generatesConfirmationEvent() {
Content requestConfirmationCallContent =
Content.fromParts(Part.fromFunctionCall("request_confirmation_tool", ImmutableMap.of()));
Content response1 = Content.fromParts(Part.fromText("response1"));
Expand Down Expand Up @@ -107,7 +129,51 @@ public void toolRequestConfirmation_eventHasNonNullId() {
.collect(toImmutableList());

assertThat(confirmationEvents).isNotEmpty();
assertThat(confirmationEvents.get(0).id()).isNotNull();

Event confirmationEvent = confirmationEvents.get(0);
assertThat(confirmationEvent.id()).isNotNull();

FunctionCall functionCall = confirmationEvent.functionCalls().get(0);
assertThat(functionCall.args().isPresent()).isTrue();

Map<String, Object> args = functionCall.args().get();
assertThat(args).containsKey("toolConfirmation");
assertThat(args).containsKey("originalFunctionCall");
}

@Test
public void normalTool_doesNotGenerateConfirmationEvent() {
Content normalCallContent =
Content.fromParts(Part.fromFunctionCall("normal_tool", ImmutableMap.of()));
Content response1 = Content.fromParts(Part.fromText("response1"));

var testLlm =
createTestLlm(
Flowable.just(createLlmResponse(normalCallContent)),
Flowable.just(createLlmResponse(response1)));

LlmAgent rootAgent =
createTestAgentBuilder(testLlm)
.name("root_agent")
.tools(ImmutableList.of(new NormalTool()))
.build();
InvocationContext invocationContext = createInvocationContext(rootAgent);

Runner runner = getRunnerAndCreateSession(rootAgent, invocationContext.session());

ImmutableList<Event> confirmationEvents =
runRunner(runner, invocationContext).stream()
.filter(
e ->
e.functionCalls().stream()
.anyMatch(
f ->
Objects.equals(
f.name().orElse(""),
Functions.REQUEST_CONFIRMATION_FUNCTION_CALL_NAME)))
.collect(toImmutableList());

assertThat(confirmationEvents).isEmpty();
}

private Runner getRunnerAndCreateSession(LlmAgent agent, Session session) {
Expand Down