refactor: Relax type constraints on callback lists in LlmAgent.Builder#938
Closed
copybara-service[bot] wants to merge 0 commit intomainfrom
Closed
refactor: Relax type constraints on callback lists in LlmAgent.Builder#938copybara-service[bot] wants to merge 0 commit intomainfrom
copybara-service[bot] wants to merge 0 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_877655758
branch
from
33ea347 to
0a9635d
Compare
copybara-service
bot
force-pushed
the
test_877655758
branch
from
0a9635d to
6e30af3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: Relax type constraints on callback lists in LlmAgent.Builder
Update builder methods to accept List<? extends CallbackBase> instead of List. This allows passing lists containing subtypes of the base callback interfaces, improving flexibility, especially all the *CallbackBase are package private interfaces.