refactor: Fixes #947 Update Spring Boot version , Spring AI version, organize imports#962
Conversation
…ion, organize imports
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant dependency upgrade, primarily advancing the project to Spring Boot 4.0.2 and Spring AI 2.0.0-M2. These updates are crucial for leveraging the latest features, performance enhancements, and security fixes offered by these frameworks. Additionally, the Jackson library has been updated, and its dependency management has been refactored to use a Bill of Materials (BOM), simplifying future dependency management and ensuring consistency. Minor adjustments to test class imports were also made to accommodate the new framework versions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully updates the Spring Boot and Spring AI versions, along with the Jackson library. The changes include updating version properties in pom.xml files, adding a new test dependency in dev/pom.xml, and adjusting import statements in test classes to reflect the Spring Boot changes. The introduction of jackson-bom in the parent pom.xml is a good step towards centralized dependency management. The changes align with the stated objective of refactoring and updating dependencies.
| <!-- <dependency>--> | ||
| <!-- <groupId>com.fasterxml.jackson.core</groupId>--> | ||
| <!-- <artifactId>jackson-core</artifactId>--> | ||
| <!-- <version>${jackson.version}</version>--> | ||
| <!-- </dependency>--> | ||
| <!-- <dependency>--> | ||
| <!-- <groupId>com.fasterxml.jackson.core</groupId>--> | ||
| <!-- <artifactId>jackson-annotations</artifactId>--> | ||
| <!-- <version>${jackson.version}</version>--> | ||
| <!-- </dependency>--> | ||
| <!-- <dependency>--> | ||
| <!-- <groupId>com.fasterxml.jackson.core</groupId>--> | ||
| <!-- <artifactId>jackson-databind</artifactId>--> | ||
| <!-- <version>${jackson.version}</version>--> | ||
| <!-- </dependency>--> | ||
| <!-- <dependency>--> | ||
| <!-- <groupId>com.fasterxml.jackson.datatype</groupId>--> | ||
| <!-- <artifactId>jackson-datatype-jdk8</artifactId>--> | ||
| <!-- <version>${jackson.version}</version>--> | ||
| <!-- </dependency>--> | ||
| <!-- <dependency>--> | ||
| <!-- <groupId>com.fasterxml.jackson.datatype</groupId>--> | ||
| <!-- <artifactId>jackson-datatype-jsr310</artifactId>--> | ||
| <!-- <version>${jackson.version}</version>--> | ||
| <!-- </dependency>--> | ||
| <!-- <dependency>--> | ||
| <!-- <groupId>com.fasterxml.jackson.dataformat</groupId>--> | ||
| <!-- <artifactId>jackson-dataformat-yaml</artifactId>--> | ||
| <!-- <version>${jackson.version}</version>--> | ||
| <!-- </dependency>--> |
There was a problem hiding this comment.
After introducing the jackson-bom in the dependencyManagement section, these individual Jackson dependencies are now managed by the BOM. For better clarity and to avoid clutter, it would be cleaner to remove these commented-out dependencies entirely rather than leaving them commented. This aligns with good dependency management practices in Maven, where BOMs are used to centralize and simplify dependency declarations.
Repository Style Guide Reference: The principle of clean and efficient dependency management, while not explicitly stated for Maven POMs, is analogous to the 'Import Style' guideline (line 93) which promotes clarity and efficiency in code.
References
- The principle of clean and efficient dependency management, while not explicitly stated for Maven POMs, is analogous to the 'Import Style' guideline which promotes clarity and efficiency in code. (link)
1 participant
Update Spring Boot version to 4.0.2, update Spring AI to 2.0.0-M2, organize corresponding imports.
Note: Jackson has a minor update from 2.19.0 to 2.20.0.
Spring Boot 4.x uses Jackson 3, however with switching to the jackson-bom the major version remains the same
Updated modules:
/dev
/contrib/spring-ai