Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions core/src/main/java/com/google/adk/events/EventActions.java
Original file line number Diff line number Diff line change
Expand Up @@ -165,13 +165,20 @@ public void setRequestedAuthConfigs(
}

@JsonProperty("requestedToolConfirmations")
public ConcurrentMap<String, ToolConfirmation> requestedToolConfirmations() {
public Map<String, ToolConfirmation> requestedToolConfirmations() {
return requestedToolConfirmations;
}

public void setRequestedToolConfirmations(
ConcurrentMap<String, ToolConfirmation> requestedToolConfirmations) {
this.requestedToolConfirmations = requestedToolConfirmations;
Map<String, ToolConfirmation> requestedToolConfirmations) {
if (requestedToolConfirmations == null) {
this.requestedToolConfirmations = new ConcurrentHashMap<>();
} else if (requestedToolConfirmations instanceof ConcurrentMap) {
this.requestedToolConfirmations =
(ConcurrentMap<String, ToolConfirmation>) requestedToolConfirmations;
} else {
this.requestedToolConfirmations = new ConcurrentHashMap<>(requestedToolConfirmations);
}
}

@JsonProperty("endOfAgent")
Expand Down Expand Up @@ -351,8 +358,16 @@ public Builder requestedAuthConfigs(

@CanIgnoreReturnValue
@JsonProperty("requestedToolConfirmations")
public Builder requestedToolConfirmations(ConcurrentMap<String, ToolConfirmation> value) {
this.requestedToolConfirmations = value;
public Builder requestedToolConfirmations(@Nullable Map<String, ToolConfirmation> value) {
if (value == null) {
this.requestedToolConfirmations = new ConcurrentHashMap<>();
return this;
}
if (value instanceof ConcurrentMap) {
this.requestedToolConfirmations = (ConcurrentMap<String, ToolConfirmation>) value;
} else {
this.requestedToolConfirmations = new ConcurrentHashMap<>(value);
}
return this;
}

Expand Down
24 changes: 24 additions & 0 deletions core/src/test/java/com/google/adk/events/EventActionsTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import com.google.genai.types.Part;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
Expand Down Expand Up @@ -165,4 +166,27 @@ public void merge_failsOnMismatchedKeyTypesNestedInStateDelta() {
assertThrows(
IllegalArgumentException.class, () -> eventActions1.toBuilder().merge(eventActions2));
}

@Test
public void setRequestedToolConfirmations_withConcurrentMap_usesSameInstance() {
ConcurrentHashMap<String, ToolConfirmation> map = new ConcurrentHashMap<>();
map.put("tool", TOOL_CONFIRMATION);

EventActions actions = new EventActions();
actions.setRequestedToolConfirmations(map);

assertThat(actions.requestedToolConfirmations()).isSameInstanceAs(map);
}

@Test
public void setRequestedToolConfirmations_withRegularMap_createsConcurrentMap() {
ImmutableMap<String, ToolConfirmation> map = ImmutableMap.of("tool", TOOL_CONFIRMATION);

EventActions actions = new EventActions();
actions.setRequestedToolConfirmations(map);

assertThat(actions.requestedToolConfirmations()).isNotSameInstanceAs(map);
assertThat(actions.requestedToolConfirmations()).isInstanceOf(ConcurrentMap.class);
assertThat(actions.requestedToolConfirmations()).containsExactly("tool", TOOL_CONFIRMATION);
}
}