fix(eval): include function-call events in invocation_events when skip_summarization is set

[Koushik-Salammagari]

Link to Issue or Description of Change

Fixes #5410

Description

EvaluationGenerator.convert_events_to_eval_invocations builds
invocation_events (the intermediate tool-call record used by
TrajectoryEvaluator) by collecting all qualifying events and then excluding
the final_event from the list.

The final event is identified via event.is_final_response(), but
is_final_response() returns True for any event with
skip_summarization=True — even events that contain function_call parts
(e.g. tools that use skip_summarization to surface their result directly
without an LLM summarization step). Those events were silently dropped from
invocation_events, causing get_all_tool_calls() to return [] for the
actual invocation. The result: tool_trajectory_avg_score was always 0.0
even when the tool name and args matched the expected exactly.

Root cause: is_final_response() conflates "final user-visible response"
with "should be excluded from tool trajectory". When skip_summarization=True
the function-call event is both the final response and an intermediate step
that must appear in the trajectory.

Fix: in the list comprehension that builds invocation_events, keep an
event even when it equals final_event if it contains function calls:

# before
if e is not final_event

# after
if e is not final_event or e.get_function_calls()

Changes

• src/google/adk/evaluation/evaluation_generator.py: one-line fix
• tests/unittests/evaluation/test_evaluation_generator.py: regression test that verifies tool calls are preserved when skip_summarization=True
• tests/unittests/evaluation/test_trajectory_evaluator.py: end-to-end tests for InvocationEvents intermediate_data format (exact match → 1.0, mismatch → 0.0)

Testing Plan

pytest tests/unittests/evaluation/test_trajectory_evaluator.py \
       tests/unittests/evaluation/test_evaluation_generator.py -v
======================== 47 passed in 1.23s ============================

[rohityan]

Hi @Koushik-Salammagari , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Please fix formatting errors by running autoformat.sh

[Koushik-Salammagari]

Hi @rohityan — rebased onto latest main and ran pre-commit run --all-files (all checks pass: isort, pyink, addlicense, mdformat). Ready for re-review!

[rohityan]

Hi @Jacksunwei , can you please review this.

[Koushik-Salammagari]

Hi @rohityan @Jacksunwei — rebased onto latest main to resolve the merge conflict; the branch is mergeable again and CI is re-running. Ready whenever you have a moment to review. Thanks!

[adk-bot]

I have conducted a thorough, read-only analysis of PR #5417 in accordance with the adk-pr-analyze workflow.

I have generated a premium PR Analysis Report which is now saved and available:
📂 PR Analysis Report (pr_analysis_report.md)

Key Takeaways & Recommendations:

1. Bug Resolution: The proposed fix correctly solves Issue #5410. It ensures that intermediate evaluation event trajectories do not discard critical final_event data when skip_summarization=True is utilized.
2. Quality & Standard: Alignment with ADK framework boundaries is excellent. There are high-quality regression and integration tests protecting against future regressions.
3. Core Style Nit:
   • In evaluation_generator.py, the author annotated final_event with:

     final_event: Optional[Event] = None

   • Recommendation: Request the author to update this to ADK's preferred modern standard union syntax:

     final_event: Event | None = None

Next Steps for You:

• Recommendation: Approve/Merge with Nits. The change is ready for integration, with only a minor type-hint modernization suggested.
• Let me know if you would like me to draft a GitHub review comment or perform further checks!