Skip to content

bidi streaming improvements #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Robbilie wants to merge 3 commits into
base: main
Choose a base branch
from
Open

bidi streaming improvements #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f52be5
bidi streaming improvements
Robbilie Feb 13, 2026
4a6757e
revert disabling and forcing of toggle states
Robbilie Feb 13, 2026
b3ae767
fix boolean type mismatch
Robbilie Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/app/components/chat-panel/chat-panel.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@
alt="image"
[src]="message.inlineData.data"
(click)="openViewImageDialog.emit(message.inlineData.data)"
(load)="scrollToBottom()"
/>
</div>
} @case (MediaType.AUDIO) {
Expand Down Expand Up @@ -470,7 +471,7 @@
class="audio-rec-btn"
[class.recording]="isAudioRecording"
[matTooltip]="isAudioRecording ? i18n.turnOffMicTooltip : i18n.useMicTooltip"
[disabled]="!(isBidiStreamingEnabledObs | async)"
[disabled]="!(isBidiStreamingEnabledObs | async) || !useLive"
>
<mat-icon>mic</mat-icon>
</button>
Expand All @@ -481,7 +482,7 @@
class="video-rec-btn"
[class.recording]="isVideoRecording"
[matTooltip]="isVideoRecording ? i18n.turnOffCamTooltip : i18n.useCamTooltip"
[disabled]="!(isBidiStreamingEnabledObs | async)"
[disabled]="!(isBidiStreamingEnabledObs | async) || !useLive"
>
<mat-icon>videocam</mat-icon>
</button>
Expand Down
1 change: 1 addition & 0 deletions src/app/components/chat-panel/chat-panel.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ export class ChatPanelComponent implements OnChanges, AfterViewInit {
@Input() updatedSessionState: any|null = null;
@Input() eventData = new Map<string, any>();
@Input() selectedEvent: any = undefined;
@Input() useLive: boolean = false;
@Input() isAudioRecording: boolean = false;
@Input() isVideoRecording: boolean = false;
@Input() hoveredEventMessageIndices: number[] = [];
Expand Down
17 changes: 14 additions & 3 deletions src/app/components/chat/chat.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,11 +197,21 @@
</div>
@if (isSessionLoading === false) {
<div class="toolbar-actions">
<div class="toolbar-sse-toggle">
<div class="toolbar-live-toggle">
<mat-slide-toggle
class="example-margin"
[checked]="enableSseIndicator()"
(change)="toggleSse()"
[checked]="enableLiveIndicator()"
(change)="toggleLive()"
[disabled]="!(isBidiStreamingEnabledObs | async)"
>
{{ i18n.liveLabel }}
</mat-slide-toggle>
</div>
<div class="toolbar-streaming-toggle">
<mat-slide-toggle
class="example-margin"
[checked]="enableStreamingIndicator()"
(change)="toggleStreaming()"
[disabled]="!(isTokenStreamingEnabledObs | async)"
>
{{ i18n.tokenStreamingLabel }}
Expand Down Expand Up @@ -293,6 +303,7 @@
[updatedSessionState]="updatedSessionState()"
[eventData]="eventData"
[selectedEvent]="selectedEvent"
[useLive]="useLive"
[isAudioRecording]="isAudioRecording"
[isVideoRecording]="isVideoRecording"
[hoveredEventMessageIndices]="hoveredEventMessageIndices"
Expand Down
1 change: 1 addition & 0 deletions src/app/components/chat/chat.component.i18n.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export const CHAT_MESSAGES = {
userIdLabel: 'User ID',
loadingSessionLabel: 'Loading session...',
tokenStreamingLabel: 'Token Streaming',
liveLabel: 'SSE / Live',
createNewSessionTooltip: 'Create a new Session',
newSessionButton: 'New Session',
deleteSessionTooltip: 'Delete current session',
Expand Down
38 changes: 37 additions & 1 deletion src/app/components/chat/chat.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,43 @@ button {
align-items: center;
}

.toolbar-sse-toggle {
.toolbar-live-toggle {
@include mat.slide-toggle-overrides(
(
label-text-size: 14px,
label-text-color: var(--chat-toolbar-sse-toggle-label-text-color),
unselected-track-color:
var(--chat-toolbar-sse-toggle-unselected-track-color),
unselected-focus-track-color:
var(--chat-toolbar-sse-toggle-unselected-track-color),
unselected-hover-track-color:
var(--chat-toolbar-sse-toggle-unselected-track-color),
unselected-handle-color:
var(--chat-toolbar-sse-toggle-unselected-handle-color),
unselected-focus-handle-color:
var(--chat-toolbar-sse-toggle-unselected-handle-color),
unselected-hover-handle-color:
var(--chat-toolbar-sse-toggle-unselected-handle-color),
selected-track-color: var(--chat-toolbar-sse-toggle-selected-track-color),
selected-focus-track-color:
var(--chat-toolbar-sse-toggle-selected-track-color),
selected-hover-track-color:
var(--chat-toolbar-sse-toggle-selected-track-color),
selected-handle-color:
var(--chat-toolbar-sse-toggle-selected-handle-color),
selected-focus-handle-color:
var(--chat-toolbar-sse-toggle-selected-handle-color),
selected-hover-handle-color:
var(--chat-toolbar-sse-toggle-selected-handle-color),
track-height: 24px,
track-width: 46px,
track-outline-color: var(--chat-toolbar-sse-toggle-track-outline-color),
with-icon-handle-size: 20px,
)
);
}

.toolbar-streaming-toggle {
@include mat.slide-toggle-overrides(
(
label-text-size: 14px,
Expand Down
Loading