Skip to content

feat(otel): fix '[error parsing request]' error in the Trace tab when using semconv spans #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 16, 2026
Merged

feat(otel): fix '[error parsing request]' error in the Trace tab when using semconv spans #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/utils/trace-utils.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ describe('trace-utils', () => {
attributes: {}
};
const normalized = normalizeSpan(span);
expect(normalized.attributes['gcp.vertex.agent.llm_request']).toBeUndefined();
expect(normalized.attributes)
.not.toContain('gcp.vertex.agent.llm_request');
});

it('should extract output from logs for non-execute_tool spans', () => {
Expand Down Expand Up @@ -138,8 +139,10 @@ describe('trace-utils', () => {
attributes: {}
};
const normalized = normalizeSpan(span);
expect(normalized.attributes['gcp.vertex.agent.llm_request']).toBeUndefined();
expect(normalized.attributes['gcp.vertex.agent.llm_response']).toBeUndefined();
expect(normalized.attributes)
.not.toContain('gcp.vertex.agent.llm_request');
expect(normalized.attributes)
.not.toContain('gcp.vertex.agent.llm_response');
});
});

Expand Down
33 changes: 27 additions & 6 deletions src/utils/trace-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ import { EventTelemetry, Log, Span } from "../app/core/models/Trace";
const GCP_VERTEX_AGENT_TOOL_CALL_ARGS = 'gcp.vertex.agent.tool_call_args';
const GCP_VERTEX_AGENT_TOOL_RESPONSE = 'gcp.vertex.agent.tool_response';

const GCP_VERTEX_AGENT_LLM_REQUEST = 'gcp.vertex.agent.llm_request'
const GCP_VERTEX_AGENT_LLM_RESPONSE = 'gcp.vertex.agent.llm_response'

const EXECUTE_TOOL = 'execute_tool';
const GENERATE_CONTENT = 'generate_content';

Expand All @@ -32,14 +35,23 @@ const FUNCTION_RESPONSE = 'functionResponse';
// - semconv `execute_tool` spans
// - legacy `call_llm` spans
export const normalizeSpan = (span: Span): Span => {
return {
const normalized = {
...span,
attributes: {
...span.attributes,
'gcp.vertex.agent.llm_request': span.attributes['gcp.vertex.agent.llm_request'] ?? extractInputFromSpan(span),
'gcp.vertex.agent.llm_response': span.attributes['gcp.vertex.agent.llm_response'] ?? extractOutputFromSpan(span),
}
};
const request = span.attributes[GCP_VERTEX_AGENT_LLM_REQUEST] ??
extractInputFromSpan(span)
const response = span.attributes[GCP_VERTEX_AGENT_LLM_RESPONSE] ??
extractOutputFromSpan(span)
if (request !== undefined) {
normalized.attributes[GCP_VERTEX_AGENT_LLM_REQUEST] = request
}
if (response !== undefined) {
normalized.attributes[GCP_VERTEX_AGENT_LLM_RESPONSE] = response
}
return normalized;
};

const extractInputFromSpan = (span: Span): {[key: string]: any} | string | undefined => {
Expand Down Expand Up @@ -155,11 +167,20 @@ const stringFromLogBody = (log: Log): string => {
// - semconv `execute_tool` spans
// - legacy `call_llm` spans
export const normalizeEventTelemetry = (telemetry: EventTelemetry) => {
return {
const request =
telemetry[GCP_VERTEX_AGENT_LLM_REQUEST] ?? extractEventInput(telemetry)
const response =
telemetry[GCP_VERTEX_AGENT_LLM_RESPONSE] ?? extractEventOutput(telemetry)
const normalizedEvent = {
...telemetry,
'gcp.vertex.agent.llm_request': telemetry['gcp.vertex.agent.llm_request'] ?? extractEventInput(telemetry),
'gcp.vertex.agent.llm_response': telemetry['gcp.vertex.agent.llm_response'] ?? extractEventOutput(telemetry),
};
if (request !== undefined) {
normalizedEvent[GCP_VERTEX_AGENT_LLM_REQUEST] = request;
}
if (response !== undefined) {
normalizedEvent[GCP_VERTEX_AGENT_LLM_RESPONSE] = response;
}
return normalizedEvent;
};

const extractEventInput = (telemetry: EventTelemetry): string | undefined => {
Expand Down
Loading