Skip to content

fix(otel): handle missing attributes in normalizeSpan and fix the assertions in tests#407

Closed
copybara-service[bot] wants to merge 0 commit intomainfrom
test_884394076
Closed

fix(otel): handle missing attributes in normalizeSpan and fix the assertions in tests#407
copybara-service[bot] wants to merge 0 commit intomainfrom
test_884394076

Conversation

@copybara-service
Copy link
Copy Markdown

@copybara-service copybara-service bot commented Mar 17, 2026

fix(otel): handle missing attributes in normalizeSpan and fix the assertions in tests

This change:

  • adds optional chaining when accessing span.attributes to prevent errors if the attributes property is not present on the span object
  • uses the correct assertions for checking that request/response is not set on the normalized span when it's not present in the input

@copybara-service copybara-service bot closed this Mar 17, 2026
@copybara-service copybara-service bot deleted the test_884394076 branch March 17, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants