Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions src/app/components/chat-panel/chat-panel.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -448,20 +448,22 @@
>
<mat-icon>attach_file</mat-icon>
</button>
<button
mat-icon-button
[matMenuTriggerFor]="moreMenu"
class="function-event-button"
[matTooltip]="i18n.moreOptionsTooltip"
[disabled]="!(isManualStateUpdateEnabledObs | async)"
>
<mat-icon>more_vert</mat-icon>
</button>
<mat-menu #moreMenu="matMenu">
<span mat-menu-item [matTooltip]="i18n.updateStateMenuTooltip"
(click)="updateState.emit()"> {{ i18n.updateStateMenuLabel }}
</span>
</mat-menu>
@if (!hideMoreOptionsButton()) {
<button
mat-icon-button
[matMenuTriggerFor]="moreMenu"
class="function-event-button"
[matTooltip]="i18n.moreOptionsTooltip"
[disabled]="!(isManualStateUpdateEnabledObs | async)"
>
<mat-icon>more_vert</mat-icon>
</button>
<mat-menu #moreMenu="matMenu">
<span mat-menu-item [matTooltip]="i18n.updateStateMenuTooltip"
(click)="updateState.emit()"> {{ i18n.updateStateMenuLabel }}
</span>
</mat-menu>
}
</div>
<div>
<button
Expand Down
17 changes: 17 additions & 0 deletions src/app/components/chat-panel/chat-panel.component.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ describe('ChatPanelComponent', () => {
mockFeatureFlagService.isBidiStreamingEnabledResponse.next(true);
mockFeatureFlagService.isFeedbackServiceEnabledResponse.next(true);
mockFeatureFlagService.isInfinityMessageScrollingEnabledResponse.next(true);
mockFeatureFlagService.isMoreOptionsButtonHiddenResponse.next(false);

mockStringToColorService = new MockStringToColorService();
mockStringToColorService.stc.and.returnValue('rgb(255, 0, 0)');
Expand Down Expand Up @@ -607,6 +608,22 @@ describe('ChatPanelComponent', () => {
expect(textarea).toBeTruthy();
});
});

describe('when more options button is hidden', () => {
beforeEach(() => {
mockFeatureFlagService.isMoreOptionsButtonHiddenResponse.next(true);
fixture.detectChanges();
});

it('should not show more options button', () => {
const allButtons =
fixture.debugElement.queryAll(By.css('button[mat-icon-button]'));
const button = allButtons.find(
b => b.nativeElement.querySelector('mat-icon')
?.textContent?.trim() === 'more_vert');
expect(button).toBeFalsy();
});
});
});

describe('Loading state', () => {
Expand Down
4 changes: 3 additions & 1 deletion src/app/components/chat-panel/chat-panel.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

import {TextFieldModule} from '@angular/cdk/text-field';
import {CommonModule, NgClass} from '@angular/common';
import {AfterViewInit, ChangeDetectionStrategy, Component, DestroyRef, effect, ElementRef, EventEmitter, HostListener, inject, input, Input, OnChanges, Output, signal, SimpleChanges, Type, ViewChild} from '@angular/core';
import {AfterViewInit, ChangeDetectionStrategy, Component, DestroyRef, effect, ElementRef, EventEmitter, HostListener, inject, InjectionToken, input, Input, OnChanges, Output, signal, SimpleChanges, Type, ViewChild} from '@angular/core';
import {takeUntilDestroyed, toSignal} from '@angular/core/rxjs-interop';
import {FormsModule} from '@angular/forms';
import {MatButtonModule} from '@angular/material/button';
Expand Down Expand Up @@ -163,6 +163,8 @@ export class ChatPanelComponent implements OnChanges, AfterViewInit {
toSignal(this.featureFlagService.isFeedbackServiceEnabled());
readonly isLoadingAgentResponse =
toSignal(this.agentService.getLoadingState());
readonly hideMoreOptionsButton =
toSignal(this.featureFlagService.isMoreOptionsButtonHidden());

protected readonly onScroll = new Subject<Event>();
protected readonly sanitizer = inject(SAFE_VALUES_SERVICE);
Expand Down
4 changes: 4 additions & 0 deletions src/app/core/services/feature-flag.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,4 +130,8 @@ export class FeatureFlagService implements FeatureFlagServiceInterface {
isInfinityMessageScrollingEnabled(): Observable<boolean> {
return of(false);
}

isMoreOptionsButtonHidden(): Observable<boolean> {
return of(false);
}
}
1 change: 1 addition & 0 deletions src/app/core/services/interfaces/feature-flag.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,5 @@ export declare abstract class FeatureFlagService {
abstract isDeveloperUiDisclaimerEnabled(): Observable<boolean>;
abstract isFeedbackServiceEnabled(): Observable<boolean>;
abstract isInfinityMessageScrollingEnabled(): Observable<boolean>;
abstract isMoreOptionsButtonHidden(): Observable<boolean>;
}
4 changes: 4 additions & 0 deletions src/app/core/services/testing/mock-feature-flag.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -115,4 +115,8 @@ export class MockFeatureFlagService implements FeatureFlagService {
isInfinityMessageScrollingEnabled =
jasmine.createSpy('isInfinityMessageScrollingEnabled')
.and.returnValue(this.isInfinityMessageScrollingEnabledResponse);
isMoreOptionsButtonHiddenResponse = new ReplaySubject<boolean>(1);
isMoreOptionsButtonHidden =
jasmine.createSpy('isMoreOptionsButtonHidden')
.and.returnValue(this.isMoreOptionsButtonHiddenResponse);
}
Loading