trait Pause for device pause and resume#389
Merged
Lencerf merged 5 commits intogoogle:mainfrom Feb 5, 2026
Merged
Conversation
Replace the `MmioRange` type alias with `Arc<dyn Mmio>` to improve code clarity by making type signatures more explicit. Signed-off-by: Changyuan Lyu <changyuanl@google.com>
Move the `PvPanic` device from the `device` module to the `pci` module to resolve a circular dependency. Signed-off-by: Changyuan Lyu <changyuanl@google.com>
Create the `MmioDev` trait as an abstraction for MMIO devices, inheriting from the `Mmio` trait. Signed-off-by: Changyuan Lyu <changyuanl@google.com>
Pull Request Test Coverage Report for Build 21704213175Details
💛 - Coveralls |
Define a common interface for pausing and resuming devices. Provide a default implementation that returns a `NotPausable` error and implement the trait for all MMIO devices. Signed-off-by: Changyuan Lyu <changyuanl@google.com>
Require the `Pci` trait to implement the `Pause` trait. Signed-off-by: Changyuan Lyu <changyuanl@google.com>
Lencerf
force-pushed
the
feat/device-pause-resume
branch
from
304f305 to
93a0292
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.