Skip to content

Add OnFrameDropped override to LocalRecorder::Display #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sprangerik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add OnFrameDropped override to LocalRecorder::Display #2448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions base/cvd/cuttlefish/host/frontend/webrtc/libdevice/local_recorder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

#include <atomic>
#include <chrono>
#include <cstdint>
#include <list>
#include <mutex>
#include <thread>
Expand All @@ -27,14 +28,12 @@
#include "absl/log/log.h"

#include <api/media_stream_interface.h>
#include <api/rtp_parameters.h>
#include <api/task_queue/default_task_queue_factory.h>
#include <api/video/builtin_video_bitrate_allocator_factory.h>
#include <api/video/encoded_image.h>
#include <api/video/video_frame.h>
#include <api/video_codecs/builtin_video_encoder_factory.h>
#include <api/video_codecs/video_encoder.h>
#include <mkvmuxer/mkvmuxer.h>
#include <mkvmuxer/mkvwriter.h>
#include <system_wrappers/include/clock.h>

namespace cuttlefish {
namespace webrtc_streaming {
Expand Down Expand Up @@ -63,6 +62,9 @@ class LocalRecorder::Display
virtual webrtc::EncodedImageCallback::Result OnEncodedImage(
const webrtc::EncodedImage& encoded_image,
const webrtc::CodecSpecificInfo* codec_specific_info) override;
// TODO(sprang): Mark as override when the libwebrtc dependency is bumped.
virtual void OnFrameDropped(uint32_t rtp_timestamp, int spatial_id,
bool is_end_of_temporal_unit) {}

LocalRecorder::Impl& impl_;
std::shared_ptr<webrtc::VideoTrackSourceInterface> source_;
Expand Down
Loading