[assemble_cvd] Replace slow lsof for file cleanup#2489
Open
bridadan wants to merge 1 commit intogoogle:mainfrom
Open
[assemble_cvd] Replace slow lsof for file cleanup#2489bridadan wants to merge 1 commit intogoogle:mainfrom
bridadan wants to merge 1 commit intogoogle:mainfrom
Conversation
CleanPriorFiles called lsof to ensure files weren't in use before
deletion, but this was taking ~5 seconds, significantly slowing down
startup. lsof was slow because it scanned all processes on the
system and performed name resolutions by default.
Replacing it with a targeted C++ scan of /proc/*/fd for the current
user's processes avoids these overheads and reduces the execution time
to ~132 ms.
Bug: 401259067
Test: cvd create
check launcher.log for ~5s speed up to UBOOT start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CleanPriorFiles called lsof to ensure files weren't in use before deletion, but this was taking ~5 seconds, significantly slowing down startup. lsof was slow because it scanned all processes on the system and performed name resolutions by default.
Replacing it with a targeted C++ scan of /proc/*/fd for the current user's processes avoids these overheads and reduces the execution time to ~132 ms.
Bug: 401259067
Test: cvd create
check launcher.log for ~5s speed up to UBOOT start