Add build opt to enable all host substitutions by default#2494
Open
jmacnak wants to merge 1 commit intogoogle:mainfrom
Open
Add build opt to enable all host substitutions by default#2494jmacnak wants to merge 1 commit intogoogle:mainfrom
jmacnak wants to merge 1 commit intogoogle:mainfrom
Conversation
Bug: b/507966746 Test: Add an extra LOG() statement to assemble_cvd. ``` bazel run //cuttlefish/package:cvd \ -- create ``` and confirm it does not show the log. ``` bazel run //cuttlefish/package:cvd \ --//cuttlefish/host/commands/cvd:all_host_substitutions=true \ -- create ``` and confirm it does show the log.
jmacnak
force-pushed
the
all-host-substitutions
branch
from
fc0427f to
3bb2aa4
Compare
Databean
reviewed
Apr 30, 2026
Comment on lines
+360
to
+365
| local_defines = select({ | ||
| "//cuttlefish/host/commands/cvd:all_host_substitutions_enabled": [ | ||
| "CUTTLEFISH_ENABLE_ALL_HOST_SUBSTITUTIONS_BY_DEFAULT", | ||
| ], | ||
| "//conditions:default": [], | ||
| }), |
Member
There was a problem hiding this comment.
Does this conflict with #2491 ?
See also the discussion in b/507524719
Member
Author
There was a problem hiding this comment.
Ahh, I had not seen those yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: b/507966746
Test:
Add an extra LOG() statement to assemble_cvd.
and confirm it does not show the log.
and confirm it does show the log.