Update frontend build to go 1.25#2504
Closed
Databean wants to merge 5 commits intogoogle:mainfrom
Closed
Conversation
Assisted-by: Antigravity:Gemini Next Bug: b/508728217
…e build warnings Assisted-by: Antigravity:Gemini Next Bug: b/508728217
Assisted-by: Antigravity:Gemini Next Bug: b/508728217
Assisted-by: Antigravity:Gemini Next Bug: b/508728217
Assisted-by: Antigravity:Gemini Next Bug: b/508728217
Databean
changed the title
jemoreira
reviewed
May 2, 2026
| module github.com/google/android-cuttlefish/frontend/src/host_orchestrator | ||
|
|
||
| go 1.17 | ||
| go 1.25 |
Member
There was a problem hiding this comment.
This has been a problem in the past because external users are in older OS versions that don't have this version available. For example, ubuntu 24.04 comes with go 1.22 by default while ubuntu 22.04 comes with 1.18; the newest version that can be installed in both is 1.23.
Member
Author
There was a problem hiding this comment.
This seems to work on my machine where go version reports go version go1.24.13 linux/amd64, I validated it using tools/buildutils/build_package.sh frontend. I think older versions of go are capable of downloading newer versions, but updating the debian/control file will probably make it fail.
jemoreira
approved these changes
May 2, 2026
Member
Author
|
I tried PR #2501 with go 1.18 and it seems to build, so I'll drop this PR for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for using the go-sdk mcp library: https://github.com/modelcontextprotocol/go-sdk/blob/f5f2015413f17f578fbacc839d2c05d0fdb3f1cc/go.mod#L3
Assisted-by: Antigravity:Gemini Next
Bug: b/508728217