Tidy up cURL error messages in metrics cases#2508
Merged
cjreynol merged 2 commits intogoogle:mainfrom May 5, 2026
Merged
Conversation
During the GCE environment detection logic, the HTTP request to make the detection would print out error lines if GCE was not detected. This update makes all of the cURL outputs go into the logs, instead. It makes the V2 `metrics/metrics.log` a bit noisier, but that is better than cluttering up the command-line output with the messges. Bug: 508689956
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
jemoreira
approved these changes
May 4, 2026
jmacnak
approved these changes
May 4, 2026
And add a `clang-tidy` check to verify the comments match the parameter names.
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
jmacnak
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the GCE environment detection logic, the HTTP request to make the detection would print out error lines if GCE was not detected. This update makes all of the cURL outputs go into the logs, instead.
It makes the V2
metrics/metrics.loga bit noisier, but that is better than cluttering up the command-line output with the messages.Bug: 508689956