Stop using EmulatedAbsolutePath#2509
Open
jemoreira wants to merge 1 commit intogoogle:mainfrom
Open
Conversation
EmulateAbsolutePath was needed for the cvd server as the client may have been executing in a different directory and with a different $HOME. The function handled "~" at the begining of the path, which the cvd command shouldn't do as that's the shell's responsibility. Without the special handling for "~" and with all callers just using the current working directory, calls to the function were doing exactly the same as `AbsolutePath` or `RealPath` (with `follow_symlinks` as true or false respectively).
cjreynol
approved these changes
May 4, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EmulateAbsolutePath was needed for the cvd server as the client may have
been executing in a different directory and with a different $HOME.
The function handled "~" at the begining of the path, which the cvd
command shouldn't do as that's the shell's responsibility.
Without the special handling for "~" and with all callers just using the
current working directory, calls to the function were doing exactly the
same as
AbsolutePathorRealPath(withfollow_symlinksas true orfalse respectively).