-
Notifications
You must be signed in to change notification settings - Fork 18
feat: Add Recaptcha attestation provider #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
6154bfb
WIP: Creates new targets AppCheckCoreProvider and RecaptchaEnterprise…
hiteshmaurya56 01170d0
moves
ncooke3 0f548c2
todos
ncooke3 eb4effd
fixes
ncooke3 bfb35e3
fix custom action name
ncooke3 157bd6d
umbrella header fixes
ncooke3 a3ee169
Add agents workflow guide
ncooke3 5ac8a38
fix(recaptcha): improve safety and fix compilation issues in Recaptch…
ncooke3 4c6523e
fix(recaptcha): improve safety and fix compilation issues in Recaptch…
ncooke3 95bc4c5
docs(agent-workflow): enforce highly scannable communication style an…
ncooke3 83e6937
test(recaptcha): add comprehensive unit tests for Recaptcha Enterpris…
ncooke3 71a5698
docs(agent-workflow): add Swift/Obj-C bridging best practices and TDD…
ncooke3 0d638f2
refactor: remove forwarding headers and update imports to public headers
ncooke3 99b009e
docs: update agents.md with workflow refinements and troubleshooting
ncooke3 1eecc52
docs: refine agents.md with explicit steps and line wrapping
ncooke3 e242784
add tests and expose target in existing lib
ncooke3 a5c0fd9
add temp files for discussion
ncooke3 1847721
feat(AppCheck): depend on RecaptchaEnterpriseProvider product from ap…
ncooke3 02dc75c
rework initializers, make var a let, remove dup name
ncooke3 df9a664
feat: add assertion for missing Recaptcha SDK and update TODOs
ncooke3 9d503b9
feat(recaptcha): improve assertion for missing SDK and refactor const…
ncooke3 eb4cb4a
add clarifying comment, future todo
ncooke3 5cbadaf
refactor: prefer swift shorthand binding
ncooke3 f457a41
refactor(recaptcha): apply idiomatic Swift renames to properties and …
ncooke3 652e9f2
fixes?
ncooke3 3770f8b
feat: Implement exponential backoff for reCAPTCHA Enterprise provider
ncooke3 0f1f47b
bump podspec and changelog
ncooke3 7719b2d
fixes, new error message
ncooke3 8f511c4
remove unneeded file
ncooke3 eb8379c
refactor: address code review feedback for RecaptchaEnterpriseProvider
ncooke3 8886e93
endpoint comment
ncooke3 dd72cd4
refactor: address RecaptchaEnterprise code review feedback
ncooke3 82989b9
fixes
ncooke3 21b66e1
remove
ncooke3 3242ef9
promise fixes
ncooke3 032ceef
docs
ncooke3 f89584d
moves
ncooke3 f54e763
Apply suggestions from code review
ncooke3 356fdc7
prefer non-shorthand
ncooke3 b5ff78d
back to shorthand
ncooke3 a280438
shorthand
ncooke3 62c864e
fixes
ncooke3 2f3eddf
Adds a comment explaining the safety of the force cast in `RecaptchaE…
ncooke3 16434e8
consolidate error messaging
ncooke3 66858f1
restore comment
ncooke3 03fb421
Test cleanup
ncooke3 f8d4016
fixes
ncooke3 42270e4
fixes
ncooke3 d6a65fb
cleanup
ncooke3 b812295
refactor: remove test-specific code path in RecaptchaEnterpriseCoreTo…
ncooke3 eab77db
refactor names
ncooke3 046b206
add availability checks that mirro RecaptchaEnterprise
ncooke3 d03149e
add availability attributes to test suites
ncooke3 4ddab29
remove unneeded dep
ncooke3 5db821c
remove unneeded target stuff
ncooke3 23bd67d
refactor: Rename RecaptchaEnterprise to Recaptcha
ncooke3 edc0083
fix(ci): install simulators for requested platforms, skipping macOS
ncooke3 26c88aa
review #3
ncooke3 aff324c
review 1
ncooke3 11b09cf
refactor(recaptcha): rename RecaptchaSDK to RecaptchaEnterpriseSDKLoader
ncooke3 065572a
refactor, move out exception handling
ncooke3 f67b54f
deletes
ncooke3 5e15847
finish moves
ncooke3 7a5798b
refactor: optimize recaptcha sdk loader and linking check
ncooke3 3e8e012
refactor(recaptcha): avoid NSNull in NSError userInfo during bridging
ncooke3 cc573d4
sitekey prop removal
ncooke3 1bdf7a9
chore: add clarifying comment for fetchClient
ncooke3 a27a56c
feat: add env var to toggle staging backend
ncooke3 e44765d
feat: replace isRecaptchaEnterpriseSDKLinked with isSupported
ncooke3 15fa108
Update AppCheckRecaptchaProvider/Sources/Public/AppCheckRecaptchaProv…
ncooke3 c115953
Update AppCheckRecaptchaProvider/Sources/Public/AppCheckRecaptchaProv…
ncooke3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: Swift was added (very likely non-breaking at this point). RecaptchaInterop and PromisesSwift deps were added (likely not breaking, esp. for SPM). Internal ObjC headers were made public (non-breaking).