Skip to content

Fix --source-filter summary message never being printed. #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rjmansfield wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −3
Open

Fix --source-filter summary message never being printed. #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/bloaty.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,12 +827,11 @@ void RollupOutput::PrettyPrint(const OutputOptions& options,

uint64_t file_filtered = 0;
uint64_t vm_filtered = 0;
uint64_t filtered = 0;
if (ShowFile(options)) {
filtered += toplevel_row_.filtered_size.file;
file_filtered = toplevel_row_.filtered_size.file;
}
if (ShowVM(options)) {
filtered += toplevel_row_.filtered_size.vm;
vm_filtered = toplevel_row_.filtered_size.vm;
}

if (vm_filtered == 0 && file_filtered == 0) {
Expand Down
22 changes: 22 additions & 0 deletions tests/source-filter.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Test that --source-filter displays the filtering summary message.

# RUN: rm -rf %t && mkdir -p %t
# RUN: %yaml2obj %S/macho/no-dsym.test -o %t/test_binary

# Test 1: Both domains - should show file and vm omitted sizes
# RUN: %bloaty %t/test_binary -d sections --source-filter="text" | %FileCheck --check-prefix=BOTH %s
# BOTH: __TEXT,__text
# BOTH: TOTAL
# BOTH: Filtering enabled (source_filter); omitted

# Test 2: VM only - should show vm omitted size
# RUN: %bloaty %t/test_binary -d sections --domain=vm --source-filter="text" | %FileCheck --check-prefix=VM %s
# VM: __TEXT,__text
# VM: TOTAL
# VM: Filtering enabled (source_filter); omitted

# Test 3: File only - should show file omitted size
# RUN: %bloaty %t/test_binary -d sections --domain=file --source-filter="text" | %FileCheck --check-prefix=FILE %s
# FILE: __TEXT,__text
# FILE: TOTAL
# FILE: Filtering enabled (source_filter); omitted