fix a few HCI types and make the bridge more robust#877
Merged
barbibulle merged 5 commits intomainfrom Feb 2, 2026
Merged
Conversation
barbibulle
force-pushed
the
gbg/hci-fixes
branch
3 times, most recently
from
f1db56e to
27a6f0a
Compare
barbibulle
force-pushed
the
gbg/hci-fixes
branch
from
27a6f0a to
c901e15
Compare
zxzxwu
approved these changes
Feb 1, 2026
bumble/device.py
Outdated
| self.public_address = response.bd_addr | ||
| except hci.HCI_Error: | ||
| logger.debug('Controller has no public address') | ||
| pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a few HCI types.
Fix the way return parameters are parsed.
Fix the way command complete and command status event flow control is supported.
The
send_sync_commandhas been split now into two commands:send_sync_commandthat always checks the status and returns a class instance, andsend_sync_command_rawthat does not check the status and returns anHCI_Command_Complete_Event. This allows for better type checking than having acheck_statusargument, with a return type that could depend on that argument.