resolve addresses when connecting to bonded peers#879
Merged
barbibulle merged 3 commits intomainfrom Jan 31, 2026
Merged
Conversation
zxzxwu
approved these changes
Jan 31, 2026
zxzxwu
reviewed
Jan 31, 2026
bumble/device.py
Outdated
| if self.is_le_connecting: | ||
| raise InvalidStateError('connection already pending') | ||
|
|
||
| try_resolve = True |
Collaborator
There was a problem hiding this comment.
Shall we only enable this feature when not using resolution offloading?
Collaborator
Author
There was a problem hiding this comment.
Yes, good point. I made the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When connecting to a bonded peer, it's almost always necessary to resolve the address (or connect to the public/static address if RPA isn't used).
This should have always been the default, but wasn't for some reason.
To make things a bit easier to maintain, the
connectmethod was split intoconnect_leandconnect_classicbecause they really don't share much in common.