Allow zones to be provided for disks and instances#541
Merged
Fryyyyy merged 18 commits intogoogle:mainfrom Apr 14, 2026
Merged
Conversation
Updated `CreateDiskFromSnapshot` in the GCP compute provider to allow users to specify an optional `dest_project` and `dest_zone` when creating a disk from a snapshot. The method defaults to the instance's `project_id` and `default_zone` if these are not provided. Included unit tests to verify behavior.
Updated `CreateDiskFromSnapshot` in the GCP compute provider to allow users to specify an optional `dest_project` and `dest_zone` when creating a disk from a snapshot. The method defaults to the instance's `project_id` and `default_zone` if these are not provided. Included unit tests to verify behavior. Fixes BlockOperation parameter passing.
…5322369123445590457 feat(gcp): Add optional destination project and zone to CreateDiskFromSnapshot
ramo-j
approved these changes
Apr 14, 2026
Contributor
ramo-j
left a comment
ramo-j
left a comment
There was a problem hiding this comment.
Just one readability nit, otherwise, LGTM.
Co-authored-by: Ramo <ramo_j@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than listing all of them, which causes timeouts in large projects