Idiomatic Rust: Improve section on extension traits#3083
Merged
Conversation
We make 3 changes:
1. We make all code snippets editable. This makes it easier to play
around with students' ideas.
2. We add a `main` function to make the code exectable where it makes
sense
3. We move extension traits for `str` from `&str` to `str`. There is no
need for the reference if the methods take `&self`.
mgeisler
approved these changes
Feb 7, 2026
Collaborator
mgeisler
left a comment
mgeisler
left a comment
There was a problem hiding this comment.
Thanks!
Cc @tall-vase for future reference. It's critically important that the teacher can edit the code blocks so we can use them to answer questions while teaching. The class is about "showing, not telling" so we keep editing code blocks to show the students what we mean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We make 3 changes:
mainfunction to make the code exectable where it makes sensestrfrom&strtostr. There is no need for the reference if the methods take&self.