Propagate must_bind_ flag to ImportUnsupportedItem in FunctionDeclImporter.#936
Merged
copybara-service[bot] merged 1 commit intomainfrom May 5, 2026
Merged
Propagate must_bind_ flag to ImportUnsupportedItem in FunctionDeclImporter.#936copybara-service[bot] merged 1 commit intomainfrom
must_bind_ flag to ImportUnsupportedItem in FunctionDeclImporter.#936copybara-service[bot] merged 1 commit intomainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_907415097
branch
from
6134652 to
734e09f
Compare
…clImporter`. This ensures that failure to bind a function annotated with `CRUBIT_MUST_BIND` results in a hard error during analysis, rather than generating invalid bindings. Also updated `ImportContext` interface and `Importer` implementation to support passing `is_hard_error` to `ImportUnsupportedItem`. PiperOrigin-RevId: 910551184
copybara-service
Bot
force-pushed
the
test_907415097
branch
from
734e09f to
0cd000e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate
must_bind_flag toImportUnsupportedIteminFunctionDeclImporter.This ensures that failure to bind a function annotated with
CRUBIT_MUST_BINDresults in a hard error during analysis, rather than generating invalid bindings.
Also updated
ImportContextinterface andImporterimplementation to supportpassing
is_hard_errortoImportUnsupportedItem.