Crubit: improve error message for unbindable type used by value#940
Merged
copybara-service[bot] merged 1 commit intomainfrom May 5, 2026
Merged
Crubit: improve error message for unbindable type used by value#940copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_909918918
branch
from
c0722f6 to
c825f4d
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_909918918
branch
2 times, most recently
from
a7b7a6d to
42c20f4
Compare
When a type cannot be bound (results in RsTypeKind::Error), and it is used by value in a function, the error message was missing the actual type name. This CL updates check_by_value in rs_snippet.rs to include the symbol name in the error message. PiperOrigin-RevId: 910546676
copybara-service
Bot
force-pushed
the
test_909918918
branch
from
42c20f4 to
d9ada01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crubit: improve error message for unbindable type used by value
When a type cannot be bound (results in RsTypeKind::Error), and it is used by value in a function, the error message was missing the actual type name.
This CL updates check_by_value in rs_snippet.rs to include the symbol name in the error message.