Skip to content

C++: Fix signed integer overflow in AddInt64Noise. #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

C++: Fix signed integer overflow in AddInt64Noise. #402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions cc/algorithms/numerical-mechanisms.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,10 @@ int64_t LaplaceMechanism::AddInt64Noise(int64_t result) {
granularity = granularity_cast_result.value;
}

return RoundToNearestInt64Multiple(result, granularity) +
noise_cast_result.value;
SafeOpResult<int64_t> add_result =
SafeAdd(RoundToNearestInt64Multiple(result, granularity),
noise_cast_result.value);
return add_result.value;
}

absl::StatusOr<std::unique_ptr<NumericalMechanism>>
Expand Down Expand Up @@ -411,8 +413,10 @@ int64_t GaussianMechanism::AddInt64Noise(int64_t result) {
granularity = granularity_cast_result.value;
}

return RoundToNearestInt64Multiple(result, granularity) +
noise_cast_result.value;
SafeOpResult<int64_t> add_result =
SafeAdd(RoundToNearestInt64Multiple(result, granularity),
noise_cast_result.value);
return add_result.value;
}

} // namespace differential_privacy
Loading