Use UIGraphicsImageRenderer in GTMUIImage+Resize. (#541)#572
Merged
thomasvl merged 1 commit intogoogle:mainfrom Nov 6, 2025
Merged
Use UIGraphicsImageRenderer in GTMUIImage+Resize. (#541)#572thomasvl merged 1 commit intogoogle:mainfrom
thomasvl merged 1 commit intogoogle:mainfrom
Conversation
This reverts commit d368b17, which was for "Revert the changes to iPhone/GTMUIImage+Resize.m (google#552)", but also includes the following additional changes to fix the reason for google#552. Use source image scale in gtm_imageByResizingToSize. This matches the way scale is set in gtm_imageByRotating. Add tests to verify that image scale is preserved.
Contributor
Author
|
PTAL @thomasvl |
thomasvl
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit d368b17, which was for "Revert the changes to iPhone/GTMUIImage+Resize.m (#552)", but also includes the following additional changes to fix the reason for #552.
Use source image scale in gtm_imageByResizingToSize. This matches the way scale is set in gtm_imageByRotating.
Add tests to verify that image scale is preserved.