fix usage of undefined env. var in itests#791
Open
rursprung wants to merge 1 commit intogoogle:mainfrom
Open
Conversation
so far, the integration tests relied on the `CARGO_TARGET_DIR` env. variable. this usage was wrong since the variable is not actually set, so the fallback `"target"` was always used. `CARGO_MANIFEST_DIR` is always set and we know that the target directory is one level up from there, so we can use that instead. `std::path::Path` is used to ensure that the correct path separator is used. the `run_integration_tests.sh` script is not affected by this since it is meant to be launched from the project root directory and then the path constructed so far already worked. but if running the tests e.g. from an IDE (after compiling the itest binaries) then the working directory will be in the `integration_tests` subfolder and the constructed path will be wrong (this is how i initially noticed this bug).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so far, the integration tests relied on the
CARGO_TARGET_DIRenv. variable. this usage was wrong since the variable is not actually set, so the fallback"target"was always used.CARGO_MANIFEST_DIRis always set and we know that the target directory is one level up from there, so we can use that instead.std::path::Pathis used to ensure that the correct path separator is used.the
run_integration_tests.shscript is not affected by this since it is meant to be launched from the project root directory and then the path constructed so far already worked. but if running the tests e.g. from an IDE (after compiling the itest binaries) then the working directory will be in theintegration_testssubfolder and the constructed path will be wrong (this is how i initially noticed this bug).