Fix terms of service clearing all data when accessing it offline#3797
Open
andreia-ferreira wants to merge 4 commits into
Open
Fix terms of service clearing all data when accessing it offline#3797andreia-ferreira wants to merge 4 commits into
andreia-ferreira wants to merge 4 commits into
Conversation
… to load when the screen isViewOnly=true
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3797 +/- ##
============================================
- Coverage 66.59% 66.55% -0.05%
- Complexity 1683 1685 +2
============================================
Files 392 392
Lines 10145 10183 +38
Branches 1295 1297 +2
============================================
+ Hits 6756 6777 +21
- Misses 2712 2729 +17
Partials 677 677
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3763
When clicking on the Terms of Service in the home drawer when offline, the app would instantly logout the user. This could cause data loss, since the user could have pending submissions and the logout process clears all data.
This PR updates the
TermsOfServiceViewModelso that when the user already accepted the terms of service (whenisViewOnly=true) the screen will have a simple error state with a retry button, which a user can attempt to retry loading the terms.Before:
Screen_recording_20260619_115529.webm
After:
Screen_recording_20260619_121230.webm
@shobhitagarwal1612 PTAL?