Skip to content

Conversation

@sidd190
Copy link
Contributor

@sidd190 sidd190 commented Jan 29, 2026

In Survey Options, styling fixed to highlight/underline options for select one/multiple only when hovered or selected

Fixes #1655

Before -

Screencast.from.2026-01-28.16-55-51.webm

After -

Screencast.from.2026-01-29.21-27-42.webm

…s for select one/multiple only when hovered or selected
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sidd190, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the user interface for survey options in the create/edit survey flow. It specifically targets the styling of input fields for 'select one/multiple' options, ensuring that visual cues like underlines are displayed contextually (on hover or focus) rather than persistently. Additionally, it enhances usability by introducing dynamic placeholders for these input fields.

Highlights

  • Dynamic Underline Display: Survey option underlines now only appear on hover or when the option is selected/focused, improving visual clarity and user interaction.
  • Input Placeholder: A dynamic placeholder 'Option X' has been added to the survey option input fields, providing better user guidance.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully addresses the styling issue for survey options, ensuring that underlines are only visible on hover or when an option is selected. The addition of a dynamic placeholder in the input field also enhances user experience. However, there's a maintainability concern regarding the use of ::ng-deep in the CSS.

@sidd190
Copy link
Contributor Author

sidd190 commented Jan 29, 2026

Ohh no, I forgot to pull the last 2-3 commits and a major refactor was merged I think by @gino-m 's PR around related files. Closing this now, will re-open on the updated codebase. 😿

@sidd190 sidd190 closed this Jan 29, 2026
@sidd190 sidd190 reopened this Jan 30, 2026
@sidd190
Copy link
Contributor Author

sidd190 commented Jan 30, 2026

@gino-m @rfontanarosa, please take a look whenever possible. Thanks.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.58%. Comparing base (f389d7b) to head (ad2bbf2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2419   +/-   ##
=======================================
  Coverage   59.58%   59.58%           
=======================================
  Files         111      111           
  Lines        2769     2769           
  Branches      405      405           
=======================================
  Hits         1650     1650           
  Misses       1061     1061           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Create / edit survey] Options in should not be highlighted / underlined unless hovered

2 participants