Prepare for initial J2KT support in common.hash.#8358
Merged
copybara-service[bot] merged 1 commit intomasterfrom Apr 17, 2026
Merged
Prepare for initial J2KT support in common.hash.#8358copybara-service[bot] merged 1 commit intomasterfrom
common.hash.#8358copybara-service[bot] merged 1 commit intomasterfrom
Conversation
...which is coming in cl/899584452. This includes: - Add lots of `@J2ktIncompatible` annotations. - Add a missing `@Nullable` annotation to `ExpectedHashCode.asLong` in `HashCodeTest`. Bonus: Migrate off deprecated `Hashing.sha1` in `HashCodeTest`, which doesn't actually care about which specific hash function it uses. (OK, in `testPadToLongWith1Byte`, it cares that it has a hash function with a very short output, so it uses `crc8`.) RELNOTES=n/a PiperOrigin-RevId: 901327552
copybara-service
bot
force-pushed
the
test_900934160
branch
from
3876102 to
8cfb330
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare for initial J2KT support in
common.hash....which is coming in cl/899584452.
This includes:
@J2ktIncompatibleannotations.@Nullableannotation toExpectedHashCode.asLonginHashCodeTest.Bonus: Migrate off deprecated
Hashing.sha1inHashCodeTest, which doesn't actually care about which specific hash function it uses. (OK, intestPadToLongWith1Byte, it cares that it has a hash function with a very short output, so it usescrc8.)RELNOTES=n/a