Refactor restorer.restore to extract post-restore work#13106
Merged
copybara-service[bot] merged 1 commit intomasterfrom May 7, 2026
Merged
Refactor restorer.restore to extract post-restore work#13106copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
copybara-service
Bot
force-pushed
the
test/cl911600246
branch
from
63470bf to
16862f1
Compare
- Extracted the inline goroutine function from the `restore` method into a new method `restorer.postRestore`. - Passed `*timing.Timer` to `postRestore` and moved `timer.Log()` to the end of `postRestore` to ensure asynchronous logging after all background work (including page loading) completes, avoiding spawning an extra goroutine. PiperOrigin-RevId: 911655209
copybara-service
Bot
force-pushed
the
test/cl911600246
branch
from
16862f1 to
7b19947
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor restorer.restore to extract post-restore work
restoremethod into anew method
restorer.postRestore.*timing.TimertopostRestoreand movedtimer.Log()to the endof
postRestoreto ensure asynchronous logging after all background work(including page loading) completes, avoiding spawning an extra goroutine.