Compatibility test suite: add WordPress, Gitea, Nextcloud#13647
Open
copybara-service[bot] wants to merge 1 commit into
Open
Compatibility test suite: add WordPress, Gitea, Nextcloud#13647copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
The first stage of the gVisor application compatibility test suite. This commit adds: - A compatibility testing helper library, containing e.g. logic to write service config files, wait for a service to be up, and make HTTP requests - Initial tests for WordPress 7.0.0, Gitea 1.26.2, and Nextcloud 34.0.0. A large library of test stacks is ready, however I am splitting them into smaller commits in the interest of review size. (If you want to preview *all* of them, see the [relkochta/compat-all branch](https://github.com/relkochta/gvisor/tree/relkochta/compat-all) on relkochta/gvisor). Tests first consist of a stack of images under images/compatibility/. This is done both for consistency with the existing image tests and so that the Dockerfiles can be modified, for example to install client or benchmarking tools to aid with testing. The tests themselves are written in Go and placed in test/compatibility/. These tests are kept separate from the existing image tests for a few reasons. First, the image tests mainly exist to find gVisor regressions; however, a core goal of the compatibility tests is to detect when updates to *third-party applications* cause them to stop working in gVisor. Second, it's probably not a good idea to include the compatibility tests in our CI/CD pipeline (at least, not yet) due to concerns about flaky tests and/or increased iteration time. (Maybe they should be run before a release is cut, though?) Once the compatibility tests are merged, I'll submit the website portion which lists the applications we have tested to be compatible. Each entry contains a link to its corresponding compatibility test in our GitHub repository. test/compatibility/README.md is included with instructions on running the tests. FUTURE_COPYBARA_INTEGRATE_REVIEW=#13645 from relkochta:relkochta/compat-stage1 172dcd7 PiperOrigin-RevId: 944186705
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility test suite: add WordPress, Gitea, Nextcloud
The first stage of the gVisor application compatibility test suite. This commit adds:
A large library of test stacks is ready, however I am splitting them into smaller commits in the interest of review size. (If you want to preview all of them, see the relkochta/compat-all branch on relkochta/gvisor).
Tests first consist of a stack of images under images/compatibility/. This is done both for consistency with the existing image tests and so that the Dockerfiles can be modified, for example to install client or benchmarking tools to aid with testing.
The tests themselves are written in Go and placed in test/compatibility/.
These tests are kept separate from the existing image tests for a few reasons. First, the image tests mainly exist to find gVisor regressions; however, a core goal of the compatibility tests is to detect when updates to third-party applications cause them to stop working in gVisor. Second, it's probably not a good idea to include the compatibility tests in our CI/CD pipeline (at least, not yet) due to concerns about flaky tests and/or increased iteration time. (Maybe they should be run before a release is cut, though?)
Once the compatibility tests are merged, I'll submit the website portion which lists the applications we have tested to be compatible. Each entry contains a link to its corresponding compatibility test in our GitHub repository.
test/compatibility/README.md is included with instructions on running the tests.
FUTURE_COPYBARA_INTEGRATE_REVIEW=#13645 from relkochta:relkochta/compat-stage1 172dcd7