Fix: Prevent Null Pointer Dereference and memory leaks in newBrushFamilyFromProtoInternal#568
Open
DarnExploit141 wants to merge 2 commits intogoogle:mainfrom
Open
Fix: Prevent Null Pointer Dereference and memory leaks in newBrushFamilyFromProtoInternal#568DarnExploit141 wants to merge 2 commits intogoogle:mainfrom
DarnExploit141 wants to merge 2 commits intogoogle:mainfrom
Conversation
Signed-off-by: proExploit1 <xxxproxxxb@gmail.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
While reviewing the fix, I noticed an additional potential null dereference that wasn't covered in this PR: jstring encoded_id_jstring =
env->NewStringUTF(std::string(encoded_id).c_str());NewStringUTF can return null on out-of-memory conditions. If this happens, passing it to CallObjectMethod would result in undefined behavior. A null check here would make the fix more complete: if (encoded_id_jstring == nullptr) {
return absl::InternalError("NewStringUTF failed (OOM).");
}I can include this in a follow-up commit if the maintainers agree. |
Signed-off-by: DARN <xxxproxxxb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a potential Null Pointer Dereference and memory leak in
brush_serialization_jni.cc.Changes:
new_id_jstringto prevent crashes ifonDecodeTexturereturns null.GetStringUTFCharsto prevent crashes on out-of-memory conditions.ReleaseStringUTFCharsto properly release the JNI memory and prevent memory leaks.