Fix typo in CaptureModeToggleUiState error message#422
Fix typo in CaptureModeToggleUiState error message#422helpingstar wants to merge 3 commits intogoogle:mainfrom
Conversation
Summary of ChangesHello @helpingstar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a small but important textual error in an error message. The change ensures that the error message displayed when an invalid capture mode is selected is grammatically correct and clear, improving the overall developer experience and message readability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a typo in an error message within CaptureModeToggleUiState.kt. The change is accurate and improves the clarity of the developer-facing error. I have also added a suggestion to simplify the surrounding logic in the init block for better code conciseness, following the project's style guide. Additionally, I noted the pull request description mistakenly refers to FlipLensUiStateAdapter, but the change is correctly applied to CaptureModeToggleUiState.
Fix typo in FlipLensUiStateAdapter error message
jetpack-camera-app/ui/uistate/capture/src/main/java/com/google/jetpackcamera/ui/uistate/capture/CaptureModeToggleUiState.kt
Lines 33 to 35 in 6ba412b
Please note: I understand that minor typo fixes might not be the priority for this project. If you prefer not to accept this type of contribution, I'm happy to close this PR. No hard feelings!