Move UiState management and extension functions out of PreviewViewModel#450
Move UiState management and extension functions out of PreviewViewModel#450davidjiagoogle merged 16 commits intomainfrom
Conversation
CaptureUiStateAdapter, QuickSettingsUiStateAdapter, DebugUiStateAdapter are created to create/update UiStates. Extension functions are turned into companion functions of the appropriate model/setting.
Summary of ChangesHello @davidjiagoogle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant refactoring effort to improve the modularity and maintainability of the camera application's UI state management. By moving Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is an excellent refactoring effort that significantly improves the architecture by moving UI state management logic and various helper functions out of the PreviewViewModel. Creating dedicated CaptureUiStateAdapter, QuickSettingsUiStateAdapter, and DebugUiStateAdapter components, and relocating extension functions to their relevant model or companion objects, makes the PreviewViewModel much cleaner and more focused. This change aligns well with the repository's style guide, particularly the principles of architectural consistency and decomposing large components, which enhances code readability, testability, and maintainability. I have one suggestion to further improve the immutability and clarity of the new adapter code.
...in/java/com/google/jetpackcamera/ui/uistateadapter/capture/compound/CaptureUiStateAdapter.kt
Outdated
Show resolved
Hide resolved
core/model/src/main/java/com/google/jetpackcamera/model/ExternalCaptureMode.kt
Show resolved
Hide resolved
feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/PreviewScreen.kt
Outdated
Show resolved
Hide resolved
...in/java/com/google/jetpackcamera/ui/uistateadapter/capture/compound/CaptureUiStateAdapter.kt
Outdated
Show resolved
Hide resolved
...in/java/com/google/jetpackcamera/ui/uistateadapter/capture/compound/CaptureUiStateAdapter.kt
Outdated
Show resolved
Hide resolved
...in/java/com/google/jetpackcamera/ui/uistateadapter/capture/compound/CaptureUiStateAdapter.kt
Outdated
Show resolved
Hide resolved
...ture/src/main/java/com/google/jetpackcamera/ui/uistateadapter/capture/DebugUiStateAdapter.kt
Outdated
Show resolved
Hide resolved
...ture/src/main/java/com/google/jetpackcamera/ui/uistateadapter/capture/DebugUiStateAdapter.kt
Show resolved
Hide resolved
...ture/src/main/java/com/google/jetpackcamera/ui/uistateadapter/capture/DebugUiStateAdapter.kt
Outdated
Show resolved
Hide resolved
feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/PreviewViewModel.kt
Outdated
Show resolved
Hide resolved
feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/PreviewViewModel.kt
Outdated
Show resolved
Hide resolved
...ture/src/main/java/com/google/jetpackcamera/ui/uistateadapter/capture/DebugUiStateAdapter.kt
Outdated
Show resolved
Hide resolved
feature/preview/src/main/java/com/google/jetpackcamera/feature/preview/PreviewScreen.kt
Outdated
Show resolved
Hide resolved
temcguir
left a comment
There was a problem hiding this comment.
There are still some unaddressed comments in QuickSettingsUiStateAdapter
CaptureUiStateAdapter, QuickSettingsUiStateAdapter, DebugUiStateAdapter are created to create/update UiStates. Extension functions are turned into companion functions of the appropriate model/setting.
CaptureUiState as returned as a combined flow via CaptureUiState.Companion.captureUiState().
SnackBarUiState and DebugUiState are moved out of CaptureUiState and are updated independently.
TrackedCapturedUiState is moved into ui/uistate module