Draft
Conversation
It is possible that the usb_loc is dynamic and changes each time the machine boot. As a result, there is no way to understand which physical usb device is related to which usb_loc. Hence introducing usb_path glob pattern such that user can always query the correct device and run necessary sub command despite the dynamic behavior. This change introduces a new command-line option `--usb_path` to htool, allowing users to select a specific USB device by providing a glob pattern that matches its real sysfs path. A new function, libhoth_get_usb_sys_path, is added to libhoth_usb to retrieve the canonical sysfs path for a given libusb_device. The device selection logic in htool_usb.c is updated to use this new path-based filtering. Also the change introduces new column in `htool usb list` showing the real path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible that the usb_loc is dynamic and changes each time the machine boot. As a result, there is no way to understand which physical usb device is related to which usb_loc. Hence introducing usb_path glob pattern such that user can always query the correct device and run necessary sub command despite the dynamic behavior.
This change introduces a new command-line option
--usb_pathto htool, allowing users to select a specific USB device by providing a glob pattern that matches its real sysfs path. A new function, libhoth_get_usb_sys_path, is added to libhoth_usb to retrieve the canonical sysfs path for a given libusb_device. The device selection logic in htool_usb.c is updated to use this new path-based filtering.Also the change introduces new column in
htool usb listshowing the real path.