test: add basic properties and env samples (#662)#1307
test: add basic properties and env samples (#662)#1307Abhijeet-ist wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds two new test files, sample.env and sample.properties, to serve as basic examples for their respective content types. The files are simple and clear as intended. I've added a couple of suggestions to align them with the POSIX standard for text files by adding a final newline character, which can improve compatibility with various tools.
| APP_ENV=development | ||
| PORT=8080 | ||
| DEBUG=true | ||
| DATABASE_URL=postgres://user:pass@localhost:5432/db No newline at end of file |
There was a problem hiding this comment.
It's a good practice for text files to end with a newline character. According to the POSIX standard, a text file is a sequence of lines, each ending with a newline. Lacking a final newline can cause issues with some tools (e.g., cat, wc, git diff). To improve compatibility and adhere to this common convention, please add a newline at the end of the file.
DATABASE_URL=postgres://user:pass@localhost:5432/db
| app.version=1.0 | ||
| database.host=localhost | ||
| database.port=5432 | ||
| feature.enabled=true No newline at end of file |
There was a problem hiding this comment.
It's a good practice for text files to end with a newline character. According to the POSIX standard, a text file is a sequence of lines, each ending with a newline. Lacking a final newline can cause issues with some tools (e.g., cat, wc, git diff). To improve compatibility and adhere to this common convention, please add a newline at the end of the file.
feature.enabled=true
1 participant
Summary
This PR adds basic test samples for the following content types:
These samples are minimal and manually written to provide clear, easy-to-recognize examples, as suggested in issue #662.
File Creation Details
propertiesfile uses a standard key=value configuration structure.envfile uses common environment variable declarations.Both files were manually created and kept intentionally simple to ensure reliable model recognition.
Closes #662