Skip to content

Document how to use magika from a Rust binary#1324

Merged
ia0 merged 2 commits intogoogle:mainfrom
ia0:doc
Mar 18, 2026
Merged

Document how to use magika from a Rust binary#1324
ia0 merged 2 commits intogoogle:mainfrom
ia0:doc

Conversation

@ia0
Copy link
Member

@ia0 ia0 commented Mar 18, 2026

Fixes #1321

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation to the Rust library on how to handle the ONNX Runtime dependency, which is a crucial piece of information for users of the library. It also includes a script to automatically keep the version number in the documentation synchronized with the one specified in Cargo.toml. The implementation is mostly correct, but the script could be made more robust against formatting changes.

@ia0 ia0 requested a review from reyammer March 18, 2026 13:02
reyammer
reyammer previously approved these changes Mar 18, 2026
@ia0 ia0 merged commit 1f90b06 into google:main Mar 18, 2026
101 of 102 checks passed
@ia0 ia0 deleted the doc branch March 18, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate crate that handles the static linking?

2 participants