Document how to use magika from a Rust binary#1324
Merged
ia0 merged 2 commits intogoogle:mainfrom Mar 18, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds documentation to the Rust library on how to handle the ONNX Runtime dependency, which is a crucial piece of information for users of the library. It also includes a script to automatically keep the version number in the documentation synchronized with the one specified in Cargo.toml. The implementation is mostly correct, but the script could be made more robust against formatting changes.
reyammer
previously approved these changes
Mar 18, 2026
reyammer
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1321