Add fn:duration:parse for Go-style duration string parsing#87
Closed
danielostrow wants to merge 1 commit intogoogle:mainfrom
Closed
Add fn:duration:parse for Go-style duration string parsing#87danielostrow wants to merge 1 commit intogoogle:mainfrom
danielostrow wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This adds a new function fn:duration:parse that parses Go-style duration
strings using time.ParseDuration. The supported format is:
[+-]<value><unit>[<value><unit>...]
Where units are: h (hours), m (minutes), s (seconds), ms (milliseconds),
us/µs (microseconds), ns (nanoseconds).
Examples:
- "1h30m" -> 1 hour 30 minutes
- "2h45m30s" -> 2 hours 45 minutes 30 seconds
- "500ms" -> 500 milliseconds
- "1.5h" -> 1.5 hours (decimal values supported)
- "-30m" -> negative 30 minutes
Note: Days ('d') are not supported by Go's time.ParseDuration.
danielostrow
force-pushed
the
feature/duration-parsing
branch
from
63d2e37 to
b05ac06
Compare
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 3, 2026
-- b05ac06 by Daniel Ostrow <dostrowh@gmail.com>: Add fn:duration:parse for Go-style duration string parsing This adds a new function fn:duration:parse that parses Go-style duration strings using time.ParseDuration. The supported format is: [+-]<value><unit>[<value><unit>...] Where units are: h (hours), m (minutes), s (seconds), ms (milliseconds), us/µs (microseconds), ns (nanoseconds). Examples: - "1h30m" -> 1 hour 30 minutes - "2h45m30s" -> 2 hours 45 minutes 30 seconds - "500ms" -> 500 milliseconds - "1.5h" -> 1.5 hours (decimal values supported) - "-30m" -> negative 30 minutes Note: Days ('d') are not supported by Go's time.ParseDuration. COPYBARA_INTEGRATE_REVIEW=#87 from danielostrow:feature/duration-parsing b05ac06 PiperOrigin-RevId: 865042763
Collaborator
|
Merged, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
fn:duration:parsefor parsing Go-style duration strings. Split from #84 per reviewer request to allow separate review of duration parsing work.What's New
Parse duration strings using Go's
time.ParseDuration:Supported units: h (hours), m (minutes), s (seconds), ms (milliseconds), us/µs (microseconds), ns (nanoseconds)
Format:
[+-]<value><unit>[<value><unit>...]Days (
d) are not supported by Go'stime.ParseDuration- use hours instead (e.g.,720hfor 30 days).Files Changed
symbols/symbols.go- addedDurationParsesymbolbuiltin/builtin.go- added type signaturefunctional/functional.go- implementation usingtime.ParseDurationfunctional/functional_test.go- comprehensive testsAll existing tests pass. New tests cover single-unit durations, combined durations, decimals, negatives, and error cases.