Fix missing order by fields in SELECT statement#203
Open
antisaling wants to merge 1 commit intogoogle:masterfrom
Open
Fix missing order by fields in SELECT statement#203antisaling wants to merge 1 commit intogoogle:masterfrom
SELECT statement#203antisaling wants to merge 1 commit intogoogle:masterfrom
Conversation
Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>
Author
|
@XinranTang hi, could you take a look? |
chensun
reviewed
Sep 25, 2024
chensun
left a comment
There was a problem hiding this comment.
Overall LGTM. But I'll defer to MLMD owner for the formal review.
nit: Can you add some unit tests for the change? It seems there're adjacent test file: ml_metadata/metadata_store/postgresql_query_executor_test.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it's not possible to order by creation time or update time when using a MySQL backend. The PostgresQL backend also won't allow ordering by update time.
All such queries fail with (e.g. on MySQL):
Description
Fixes missing order by fields in
SELECTstatement.Fixes: kubeflow/model-registry#358
How Has This Been Tested?
See opendatahub-io#12.
Merge criteria: