feat(deprecation): Add ZetaSQL deprecation warning for v1.17.2 patch release#237
Open
czgdp1807 wants to merge 1 commit intogoogle:r1.17.0from
Open
feat(deprecation): Add ZetaSQL deprecation warning for v1.17.2 patch release#237czgdp1807 wants to merge 1 commit intogoogle:r1.17.0from
czgdp1807 wants to merge 1 commit intogoogle:r1.17.0from
Conversation
This commit introduces the deprecation warning for the ZetaSQL-based `filter_query` functionality. This warning was intended for the v1.17.1 release but was missed. This change is being applied to the `r1.17` branch to enable a `v1.17.2` patch release, ensuring users are properly notified of the upcoming removal of `filter_query` in v1.18.0. Changes include: - Emitting a `DeprecationWarning` in the Python `MetadataStore` when `filter_query` is used. - Adding `LOG(WARNING)` to the C++ query executors. - Updating documentation (`RELEASE.md`, `index.md`, and docstrings) to reflect the deprecation. - Modifying tests to assert that the deprecation warnings are raised.
Collaborator
Author
|
@vkarampudi As discussed, feel free to go ahead and merge this PR. Post merging you can create a Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the deprecation warning for the ZetaSQL-based
filter_queryfunctionality.This change was originally intended for the
v1.17.1release but was inadvertently missed during the manual cherry-picking process. To ensure users receive adequate notice before the feature is removed inv1.18.0, this PR targets ther1.17branch to facilitate a new patch release,v1.17.2.The changes in this PR are directly adapted from the deprecation work in #226.
Changes
DeprecationWarningis now raised whenListOptions.filter_queryis used inget_artifacts,get_executions, orget_contexts.LOG(WARNING)is now emitted in the C++ query executors when afilter_queryis processed.RELEASE.mdfile, and docstrings have been updated to clearly state thatfilter_queryis deprecated and will be removed in v1.18.0.DeprecationWarningis correctly raised.