Skip to content

Fix integer overflow in neper latency histogram calculation #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hi-rajat-kumar merged 1 commit into from
Feb 18, 2026
Merged

Fix integer overflow in neper latency histogram calculation #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions histo.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,8 @@ static void histo_all_finalize(struct neper_histo *impl)
{
const struct percentiles *pc = &impl->thread->opts->percentiles;
double cent = impl->all_count / 100.0;
int sub = 0, v = 0, i;
int v = 0, i;
uint64_t sub = 0;

if (!impl->first_all)
return;
Expand All @@ -161,7 +162,8 @@ static void histo_one_finalize(struct neper_histo *impl)
{
const struct percentiles *pc = &impl->thread->opts->percentiles;
double cent = impl->one_count / 100.0;
int sub = 0, v = 0, i;
int v = 0, i;
uint64_t sub = 0;

for (i = impl->one_min_index; i <= impl->one_max_index; i++) {
int n = impl->cur_buckets[i];
Expand Down
9 changes: 5 additions & 4 deletions rr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
* as sending a message, opening a socket connection, or gathering statistics.
*/

#include <stdint.h>
#include <stdio.h>
#include <string.h>
#include "coef.h"
Expand Down Expand Up @@ -523,7 +524,7 @@ fn_add(struct neper_stat *stat, void *ptr)
}

static void rr_log_rtt(struct thread *tinfo, struct callbacks *cb,
int num_transactions)
uint64_t num_transactions)
{
const char *sep = " ";
const char *ext = strrchr(tinfo[0].opts->log_rtt, '.');
Expand Down Expand Up @@ -565,7 +566,7 @@ static void rr_log_rtt(struct thread *tinfo, struct callbacks *cb,

if (transactions_logged < num_transactions) {
LOG_INFO(cb,
"rtt_transactions_logged (%ld) < num_transactions (%d)",
"rtt_transactions_logged (%ld) < num_transactions (%lu)",
transactions_logged, num_transactions);
}
}
Expand All @@ -581,8 +582,8 @@ int rr_report_stats(struct thread *tinfo)
if (opts->nostats)
return 0;

int num_events = thread_stats_events(tinfo);
PRINT(cb, "num_transactions", "%d", num_events);
uint64_t num_events = thread_stats_events(tinfo);
PRINT(cb, "num_transactions", "%lu", num_events);

if (opts->client && tinfo[0].opts->log_rtt)
rr_log_rtt(tinfo, cb, num_events);
Expand Down
16 changes: 9 additions & 7 deletions thread.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,11 @@ thread_store_flow_or_die(struct thread *ts, struct flow *f) {

/* Return the total number of events across all threads. */

int thread_stats_events(const struct thread *ts)
uint64_t thread_stats_events(const struct thread *ts)
{
const struct options *opts = ts[0].opts;
int i, sum = 0;
int i;
uint64_t sum = 0;

for (i = 0; i < opts->num_threads; i++) {
struct neper_stats *stats = ts[i].stats;
Expand All @@ -156,10 +157,11 @@ int thread_stats_events(const struct thread *ts)

/* Return the total number of snapshots across all threads. */

int thread_stats_snaps(const struct thread *ts)
uint64_t thread_stats_snaps(const struct thread *ts)
{
const struct options *opts = ts[0].opts;
int i, sum = 0;
int i;
uint64_t sum = 0;

for (i = 0; i < opts->num_threads; i++) {
struct neper_stats *stats = ts[i].stats;
Expand Down Expand Up @@ -211,11 +213,11 @@ struct neper_pq *thread_stats_pq(struct thread *ts)
struct callbacks *cb = ts[0].cb;
int i;

int num_snaps = thread_stats_snaps(ts);
PRINT(cb, "num_samples", "%d", num_snaps);
uint64_t num_snaps = thread_stats_snaps(ts);
PRINT(cb, "num_samples", "%lu", num_snaps);
if (num_snaps < 2) {
LOG_ERROR(cb, "insufficient number of samples, "
"needed 2 or more, got %d", num_snaps);
"needed 2 or more, got %lu", num_snaps);
return NULL;
}

Expand Down
4 changes: 2 additions & 2 deletions thread.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,8 @@ struct thread {
long rtt_log_capacity;
};

int thread_stats_events(const struct thread *);
int thread_stats_snaps(const struct thread *);
uint64_t thread_stats_events(const struct thread *);
uint64_t thread_stats_snaps(const struct thread *);
void thread_init_noburst(struct thread *);

/* Reserves and returns the next available timeslot based on the noburst rate
Expand Down
Loading