Skip to content

Conversation

@jicelhay
Copy link
Collaborator

@jicelhay jicelhay commented Jan 16, 2026

@jicelhay jicelhay assigned jicelhay and ptkach and unassigned jicelhay Jan 16, 2026
Copy link
Collaborator

@ptkach ptkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but did you say we collect it evert 60s? It's for evert pod in every workload, so I think it's way too much metrics for what we need - I'd suggest lowering it every 5mins

@ptkach reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jicelhay).

@jicelhay
Copy link
Collaborator Author

Yes, we're just registering new metrics in the default MetricRegistry and piggybacking the logic for writing them. the existing writer is configured to write every 60 secs (see StackdriverModule.provideMetricReporter and writeIntervalSeconds in the default config yaml).

From what I see in the metrics explorer, we already pushing 30+ custom metrics, so I don't think pushing 3 more is a big issue.

Creating a configuration for a new writer + providing it and initializing as it's own process just to have these new metrics report in a different interval doesn't seem worth it for me, let me know what you think.

Copy link
Collaborator

@ptkach ptkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge and see how metrics volume changes after a week of running this in prod

@ptkach made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jicelhay).

@jicelhay jicelhay added this pull request to the merge queue Jan 21, 2026
Merged via the queue into google:master with commit a5c1412 Jan 21, 2026
9 of 10 checks passed
@jicelhay jicelhay deleted the jvmmetrics branch January 21, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants