Skip to content

Use existing pw reset code if creating from an existing instance #3091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gbrodman wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −1
Open

Use existing pw reset code if creating from an existing instance #3091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/main/java/google/registry/model/console/PasswordResetRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,9 @@ public PasswordResetRequest build() {
checkArgumentNotNull(getInstance().requester, "Requester must be specified");
checkArgumentNotNull(getInstance().destinationEmail, "Destination email must be specified");
checkArgumentNotNull(getInstance().registrarId, "Registrar ID must be specified");
getInstance().verificationCode = UUID.randomUUID().toString();
if (getInstance().verificationCode == null) {
getInstance().verificationCode = UUID.randomUUID().toString();
}
return super.build();
}

Expand Down
10 changes: 10 additions & 0 deletions core/src/test/java/google/registry/ui/server/console/PasswordResetVerifyActionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,16 @@ void testSuccess_post_lock() throws Exception {
.isTrue();
}

@Test
void testFailure_post_replay() throws Exception {
createAction("POST", verificationCode, "newPassword1").run();
assertThat(response.getStatus()).isEqualTo(HttpServletResponse.SC_OK);

// Attempting to reuse the same code should fail
createAction("POST", verificationCode, "newPassword2").run();
assertThat(response.getStatus()).isEqualTo(HttpServletResponse.SC_BAD_REQUEST);
}

@Test
void testFailure_get_invalidVerificationCode() throws Exception {
createAction("GET", "invalid", null).run();
Expand Down
Loading