vcdecoder: add memory-based output interface#77
Open
zonque wants to merge 1 commit intogoogle:masterfrom
Open
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Currently, the VCDiffStreamingDecoder class expects applications to call into ::StartDecoding() with a dictionary, and then maintains an internal buffer (decoded_target_) to accumulate pending output bytes. These are then written through ::AppendNewOutputText() and ::FlushDecodedTarget(). The problem with this implementation is that the allocation of this intermediate buffer may fail, which will then result in the application abort with a trap. This patch adds an alternative interface that does not lead to internal allocation. StartDecoding() may now optionally be called with an output buffer and a maximum length, and DecodeChunk() may be called without an OutputString parameter. If operated this way, the decoder will directly write to the provided memory buffer, which can, for instance, be mmap()ed on a block device. The old interface is kept around for full compatibility.
Author
|
I signed it! |
|
CLAs look good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
VCDiffStreamingDecoderclass expects applications to call into::StartDecoding()with a dictionary, and then maintains an internal buffer (decoded_target_) to accumulate pending output bytes. These are then written through::AppendNewOutputText()and::FlushDecodedTarget().The problem with this implementation is that the allocation of this intermediate buffer may fail, which will then result in the application abort with a trap.
This patch adds an alternative interface that does not lead to internal allocation.
StartDecoding()may now optionally be called with an output buffer and a maximum length, andDecodeChunk()may be called without anOutputStringparameter. If operated this way, the decoder will directly write to the provided memory buffer, which can, for instance, bemmap()ed on a block device.The old interface is kept around for full compatibility.
This should address #12.