tp: migrate experimental_slice_layout to use In filter on track_id#5155
Open
LalitMaganti wants to merge 1 commit intodev/lalitm/indexed-filter-infrom
Open
tp: migrate experimental_slice_layout to use In filter on track_id#5155LalitMaganti wants to merge 1 commit intodev/lalitm/indexed-filter-infrom
LalitMaganti wants to merge 1 commit intodev/lalitm/indexed-filter-infrom
Conversation
LalitMaganti
changed the title
🎨 Perfetto UI Builds
|
LalitMaganti
force-pushed
the
dev/lalitm/in
branch
from
1ffa896 to
0f90ef9
Compare
LalitMaganti
changed the base branch from
dev/lalitm/in
to
dev/lalitm/indexed-filter-in
LalitMaganti
force-pushed
the
dev/lalitm/slice-layout-in
branch
from
a156161 to
6dbdabf
Compare
LalitMaganti
force-pushed
the
dev/lalitm/indexed-filter-in
branch
from
f19f7dd to
ad716eb
Compare
LalitMaganti
force-pushed
the
dev/lalitm/slice-layout-in
branch
2 times, most recently
from
6a856db to
dd7ef11
Compare
LalitMaganti
force-pushed
the
dev/lalitm/indexed-filter-in
branch
from
ad716eb to
c4641da
Compare
Use the In filter with TypedCursor on track_id instead of a full table scan with IterateRows + unordered_set::count.
LalitMaganti
force-pushed
the
dev/lalitm/slice-layout-in
branch
from
dd7ef11 to
0eec68f
Compare
sashwinbalaji
approved these changes
Mar 17, 2026
stevegolton
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Infilter ontrack_idinexperimental_slice_layoutinstead of a full table scan withIterateRows+unordered_set::countStack