tp: use HLL cardinality estimates in query planner#5157
Draft
LalitMaganti wants to merge 1 commit intodev/lalitm/hll-computefrom
Draft
tp: use HLL cardinality estimates in query planner#5157LalitMaganti wants to merge 1 commit intodev/lalitm/hll-computefrom
LalitMaganti wants to merge 1 commit intodev/lalitm/hll-computefrom
Conversation
Wire up Column::estimated_unique_count into the query planner's equality filter row count estimation. When an HLL estimate is available, use N/unique_count instead of the old N/(2*log2(N)) heuristic. This gives SQLite more accurate cost estimates, leading to better join ordering. Fix CUJ stdlib tables to use slice.id instead of ts for row_number() ordering. slice.id is equivalent to ts ordering (slices are inserted in ts order) but is resilient to ties when multiple CUJs share the same timestamp. Fix cpu_cycles_per_thread_slice diff test to add ORDER BY id for deterministic output with LIMIT.
🎨 Perfetto UI Builds
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack