perfetto: Add latched_unsignaled field to SurfaceFrame#5159
Draft
perfetto: Add latched_unsignaled field to SurfaceFrame#5159
Conversation
This change adds a new boolean field 'latched_unsignaled' to the ActualSurfaceFrameStart proto message. This allows tracking frames that were latched by SurfaceFlinger while the buffer was still unsignaled. The Trace Processor parser is updated to extract this field and add it as a slice argument, using 'has_' checks to distinguish between the field being false and not being provided (for older traces). The field is exposed in the 'actual_frame_timeline_slice' SQL view and included in the UI frames track schema to be displayed in the details panel.
🎨 Perfetto UI Builds
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a new boolean field 'latched_unsignaled' to the
ActualSurfaceFrameStart proto message. This allows tracking frames that
were latched by SurfaceFlinger while the buffer was still unsignaled.
The Trace Processor parser is updated to extract this field and add it
as a slice argument, using 'has_' checks to distinguish between the
field being false and not being provided (for older traces).
The field is exposed in the 'actual_frame_timeline_slice' SQL view and
included in the UI frames track schema to be displayed in the details
panel.
Bug: 492301019