tools: add host side tool for string filtering#5185
Merged
LalitMaganti merged 13 commits intomainfrom Mar 19, 2026
Merged
Conversation
This was a very very dumb issue where we weren't actually using the overlay code from the config even though we had it just fine.
Extract ConvertPolicy, ConvertSemanticTypeMask, and the full bytecode+string-filter loading logic from tracing_service_impl.cc into a new shared helper: LoadMessageFilterConfig(). This avoids duplicating this logic across tools that need to load a MessageFilter from a TraceConfig's trace_filter field.
Add -i/--trace_in and -o/--trace_out flags to apply bytecode-based proto field filtering plus string filtering to a binary trace file. Uses the shared LoadMessageFilterConfig helper to load the filter configuration from a TraceConfig textproto. The existing string-only mode (positional argument) is unchanged.
🎨 Perfetto UI Builds
|
LalitMaganti
changed the title
sashwinbalaji
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple tool which allows easy testing of whether string filtering is working correctly.